Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-34227][runtime] Ensure that the scheduler close call doesn't leak IO threads into the JobMaster #26095

Merged
merged 1 commit into from
Feb 6, 2025
Merged

[FLINK-34227][runtime] Ensure that the scheduler close call doesn't leak IO threads into the JobMaster #26095

merged 1 commit into from
Feb 6, 2025

Conversation

XComp
Copy link
Contributor

@XComp XComp commented Jan 31, 2025

What is the purpose of the change

This is a follow-up PR of #24489 based on @zentol 's comment. Check the PR #24489 for more context.

This PR focuses on fixing the IO thread leakage on the SchedulerNG side.

Brief change log

  • Introduces new FutureUtils method for an async compose.
  • Make checkpointsCleaner operation complete in the main thread for AdaptiveScheduler and SchedulerBase

Verifying this change

  • Adds test method to AdaptiveSchedulerTest, DefaultSchedulerTest and AdaptiveBatchSchedulerTest

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@XComp XComp changed the title Flink 34227 scheduler close [FLINK-34227][runtime] Ensure that the scheduler close call doesn't leak IO threads into the JobMaster Jan 31, 2025
@airlock-confluentinc airlock-confluentinc bot force-pushed the FLINK-34227-scheduler-close branch from 201c979 to 04a3dca Compare January 31, 2025 12:44
@flinkbot
Copy link
Collaborator

flinkbot commented Jan 31, 2025 •
edited
Loading

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

zentol
zentol approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@zentol zentol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zentol zentol self-assigned this Feb 4, 2025
@XComp
[FLINK-34227][runtime] Fixes IO thread leaking into owner of the sche…
5adcab9 
…duler instance (i.e. the JobMaster)

- Adds test for checking whether the scheduler closing leaks an IO thread via the CheckpointsCleaner to the *SchedulerTests
- Makes CheckpointsCleaner available in AdaptiveBatchSchedulerFactory.createScheduler
@airlock-confluentinc airlock-confluentinc bot force-pushed the FLINK-34227-scheduler-close branch 2 times, most recently from 37f227f to 5adcab9 Compare February 4, 2025 18:15
@XComp
Copy link
Contributor Author

XComp commented Feb 4, 2025

fyi: I removed the main thread assertion because of the concurrent effort in #24489 where we add safeguards on the JobMaster side

@XComp
Copy link
Contributor Author

XComp commented Feb 5, 2025

Created FLINK-37259 to cover CI failure

@XComp
Copy link
Contributor Author

XComp commented Feb 5, 2025

@flinkbot run azure

@XComp XComp merged commit aae92a0 into apache:master Feb 6, 2025
@XComp XComp deleted the FLINK-34227-scheduler-close branch February 6, 2025 10:40
This was referenced Feb 6, 2025
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zentol zentol zentol approved these changes

Assignees

@zentol zentol

Labels
component=Runtime/Coordination
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XComp @flinkbot @zentol